feat: provide find and replace functionality for the default rich text editor #5206
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
f2c-ci-robot
bot
added
release-note
|
|
|
/area console |
f2c-ci-robot
bot
added
area/console
红框中的搜索高亮似乎有问题。 |
LIlGG
force-pushed
the
feat/editor-search-and-replace
branch
from
a59d8a0 to
147fe86
Compare
已解决。 |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5206 +/- ##
=========================================
Coverage 57.05% 57.05%
Complexity 3332 3332
=========================================
Files 584 584
Lines 19189 19189
Branches 1444 1444
=========================================
Hits 10949 10949
Misses 7664 7664
Partials 576 576 ☔ View full report in Codecov by Sentry. |
当输入框文字过长，会有显示问题。 |
已解决 |
f2c-ci-robot
bot
added
needs-rebase
LIlGG
force-pushed
the
feat/editor-search-and-replace
branch
from
140b7e9 to
683b8e3
Compare
Signed-off-by: Ryan Wang <i@ryanc.cc>
ruibaby
requested changes
Jan 22, 2024
console/packages/editor/src/extensions/search-and-replace/SearchAndReplace.vue
Outdated
Show resolved
Hide resolved
console/packages/editor/src/extensions/search-and-replace/SearchAndReplace.vue
Outdated
Show resolved
Hide resolved
console/packages/editor/src/extensions/search-and-replace/SearchAndReplace.vue
Outdated
Show resolved
Hide resolved
…tor-search-and-replace
…IlGG/halo into feat/editor-search-and-replace
guqing
approved these changes
Jan 24, 2024
f2c-ci-robot
bot
added
the
approved
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: guqing, JohnNiang, ruibaby The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind feature
What this PR does / why we need it:
为默认富文本编辑器添加查找与搜索的功能扩展。
快捷键：
当焦点处于编辑器中时，可以使用
Mod+f来唤起查找与搜索框，或者点击顶部工具栏来打开。当焦点处于查找与搜索框时，按下
Ecs可进行关闭。How to test it?
测试查找与搜索功能是否正常
Which issue(s) this PR fixes:
Fixes #5195
Does this PR introduce a user-facing change?